chore: Clean up profiler interface - #7062
Merged
Merged
Conversation
Contributor
Codecov Results 📊✅ 94098 passed | ⏭️ 5209 skipped | Total: 99307 | Pass Rate: 94.75% | Execution Time: 332m 34s 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 50.00%. Project has 2284 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.97% 90.32% +0.35%
==========================================
Files 193 185 -8
Lines 24946 23593 -1353
Branches 9000 8552 -448
==========================================
+ Hits 22444 21309 -1135
- Misses 2502 2284 -218
- Partials 1435 1379 -56Generated by Codecov Action |
sentrivana
marked this pull request as ready for review
August 6, 2026 13:12
alexander-alderman-webb
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
start_profile_sessionandstop_profile_session(replaced bystart_profileandstop_profile)There is a
continuous_profiling_auto_startexperimental option without a top-level replacement. There's also atry_autostart_continuous_profilerfunction that says it should be deprecated in favor of "auto lifecycle". There is no auto lifecycle as far as I can tell. Or is this referring tolifecycle=trace? Leaving this as is for now...Issues
Closes #6946
Reminders
uv run ruff.feat:,fix:,ref:,meta:)